Add tf prefix helper and test #2803
Merged
+139
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bmagyar,
destogl,
erickisos,
harderthan,
mcbed,
moriarty and
olivier-stasse
saikishor
reviewed
Nov 11, 2025
christophfroehlich
changed the title
christophfroehlich
previously approved these changes
Nov 13, 2025
Member
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
Thanks. Could you please update the diff_drive PR, so that we see the final usage?
6 tasks
saikishor
reviewed
Nov 13, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2803 +/- ##
==========================================
- Coverage 89.64% 89.63% -0.02%
==========================================
Files 152 155 +3
Lines 17815 17834 +19
Branches 1455 1459 +4
==========================================
+ Hits 15971 15985 +14
- Misses 1260 1263 +3
- Partials 584 586 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
saikishor
previously approved these changes
Nov 13, 2025
Member
saikishor
left a comment
saikishor
left a comment
There was a problem hiding this comment.
Approving as it serves the purpose.
Adding some nitpicks for future reference
kuralme
dismissed stale reviews from saikishor and christophfroehlich
via
cbd3730
bmagyar
reviewed
Nov 15, 2025
christophfroehlich
approved these changes
Nov 18, 2025
mamueluth
approved these changes
Nov 27, 2025
saikishor
approved these changes
Nov 27, 2025
Contributor
Author
|
Thanks for the approvals. Could you merge this soon so I can continue with my follow-up PRs on controllers? |
christophfroehlich
merged commit 380622f
into
ros-controls:master
13 of 16 checks passed
mergify bot
pushed a commit
that referenced
this pull request
Nov 28, 2025
(cherry picked from commit 380622f)
mergify bot
pushed a commit
that referenced
this pull request
Nov 28, 2025
(cherry picked from commit 380622f)
christophfroehlich
pushed a commit
that referenced
this pull request
Nov 28, 2025
christophfroehlich
pushed a commit
that referenced
this pull request
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the tf prefix helper here instead of control_toolbox. Prefix enabler flag re-added and frame removed from input arguments.
Related PR